Skip to content

Pass build configuration to Linux CI and use Blacksmith runners#145

Open
phnagy wants to merge 2 commits into
mainfrom
fix/linux-ci-build-configuration
Open

Pass build configuration to Linux CI and use Blacksmith runners#145
phnagy wants to merge 2 commits into
mainfrom
fix/linux-ci-build-configuration

Conversation

@phnagy

@phnagy phnagy commented Mar 17, 2026

Copy link
Copy Markdown

Pass build configuration to Linux CI and use Blacksmith runners

♻️ Current situation & Problem

The swift-test.yml@v2 Linux CI job matrix includes Debug and Release configs but never passes build_configuration, so both matrix entries build the same default configuration. Additionally, the jobs use default GitHub runners, which are slow for Release builds.

⚙️ Release Notes

Fix Linux CI to build both Debug and Release configurations and switch to Blacksmith runners for faster builds.

📚 Documentation

-/-

✅ Testing

-/-

Code of Conduct & Contributing Guidelines

Summary by CodeRabbit

  • Chores
    • Updated CI workflow to pass the selected build configuration into the Linux unit test step, ensuring unit tests run with the same build settings as other pipelines. No runtime or test logic changes; this aligns test execution with configured build variations and improves consistency in CI results.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d67757d3-5ab7-48ca-83f9-a0243d93d853

📥 Commits

Reviewing files that changed from the base of the PR and between 7dbacec and c9ddbaa.

📒 Files selected for processing (1)
  • .github/workflows/build-and-test.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-and-test.yml

📝 Walkthrough

Walkthrough

The pull request adds a build_configuration input to the mhc_utils_unit_tests_linux workflow step, passing matrix.config into the invoked swift-test.yml workflow. No other logic or control-flow changes were made.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/build-and-test.yml
Added build_configuration: ${{ matrix.config }} to the mhc_utils_unit_tests_linux job step that calls swift-test.yml; no other changes to control flow or error handling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped in the CI, left a tiny clue,
A build flag carried from matrix to view,
Tests on Linux now know which art to bake,
A rabbit's small tweak for a smoother wake. 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the two main changes: passing build configuration to Linux CI and switching to Blacksmith runners, which aligns with the PR's primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/linux-ci-build-configuration
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phnagy phnagy force-pushed the fix/linux-ci-build-configuration branch from 7dbacec to c9ddbaa Compare March 17, 2026 23:56

@PSchmiedmayer PSchmiedmayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once the CI is passing here.

@codecov

codecov Bot commented Mar 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.66%. Comparing base (d793eb5) to head (6731b28).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files         210      210           
  Lines        2727     2727           
=======================================
  Hits         1845     1845           
  Misses        882      882           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d793eb5...6731b28. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants