v2 questionnaires; update dependencies#155
Conversation
github-project-automation
Bot
moved this to In Progress
in MyHeart Counts Project Planning
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PSchmiedmayer
left a comment
PSchmiedmayer
left a comment
There was a problem hiding this comment.
Did a first pass; let me know once the PR is ready to be merged for a full review; thanks for working on all of this 🚀
There was a problem hiding this comment.
TODO to use tagged versions here before the merge.
|
|
||
| var body: some View { | ||
| Group { | ||
| Group { // TODO use a `VStack(spacing: 0)` here? |
There was a problem hiding this comment.
Nice, thank you for adding the abstraction here!
| import class ModelsR4.Questionnaire | ||
| import MyHeartCountsShared | ||
| import ResearchKitSwiftUI | ||
| import ResearchKitSwiftUI // TODO WHY???? |
There was a problem hiding this comment.
TODO to be resolved.
| import MHCStudyDefinition | ||
| import OSLog | ||
| import ResearchKitSwiftUI | ||
| import ResearchKitSwiftUI // TODO WHY???? |
There was a problem hiding this comment.
TODO to be resolved.
| fatalError("TODO") | ||
| // try await self.init(SpeziFHIR.FHIRResource.initialize(basedOn: record, using: healthKit, loadHealthKitAttachments: true)) |
There was a problem hiding this comment.
TODO to be resolved.
| } catch { | ||
| await logger.error("Failed to convert QuestionnaireResponses to FHIR: \(error)") | ||
| } | ||
| // // shouldn't be necessary, but we had some issues with these not being properly set |
There was a problem hiding this comment.
Do we still need that?
2 participants
v2 questionnaires; update dependencies
⚙️ Release Notes
📚 Documentation
todo
✅ Testing
todo
Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: