Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report
File CoverageNo changed files found. |
|
✅ CI 성공 (빌드 & 린트 통과) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive suite of unit and integration tests covering middleware routing, authentication utilities, Zod schemas, and form submission handlers for sign-in and sign-up processes. The feedback provided focuses on enhancing test maintainability and coverage. Key suggestions include refactoring timer cleanup using afterEach in middleware tests, improving assertion specificity for schema validation errors, creating helper functions to reduce duplication when mocking global objects like window.location, and ensuring that side effects like toast notifications are verified during validation failures.
|
✅ CI 성공 (빌드 & 린트 통과) |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ CI 성공 (빌드 & 린트 통과) |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a new testing guide and comprehensive unit tests for middleware, user schemas, authentication utilities, and form handlers. The reviewer identified missing test coverage for specific middleware routing rules and suggested improvements for test isolation and assertion completeness in the sign-in form tests.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ CI 성공 (빌드 & 린트 통과) |
3 participants
💡 PR 요약
auth 관련 핵심 로직에 대한 유닛 테스트를 추가합니다.
📋 테스트 목록
src/entities/user/model/__tests__/schema.test.tssrc/shared/utils/__tests__/auth.test.tssrc/__tests__/middleware.test.tssrc/widgets/signin/lib/__tests__/handleSigninFormSubmit.test.tssrc/widgets/signup/lib/__tests__/handleSignupFormSubmit.test.ts✅ 테스트 결과
🤖 Generated with Claude Code