feat: add 'switch' job action #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is mostly done. Remaining items:
|
- Change the HTTP error to be thrown before database operations. - Add docstring
- Load creators via a moduleref at runtime - Add test (previous version was copy-pasted) - validate scope
Add tests for all case types
It is clearer to use separate keywords for these rather than relying on parsing. It also allows matching non-string literals.
- Improve tests - Support matching to multiple datasets as long as the property resolves to a single value
nitrosx
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new 'switch' job action allowing logical control of the actions
Motivation
This is needed by PSI to support multiple archive systems as part of #1405
Fixes
Changes:
Tests included
Documentation
official documentation info
SciCatProject/documentation#68