fix: migrate affected datasets where size numberOfFiles packedSize and numberOfFilesArchived were overwritten #1854
Conversation
martin-trajanovski
added
bug
| 0, | ||
| ); | ||
|
|
||
| const datasetSizeSum = origDatablockSizeSum + datablockSizeSum; |
There was a problem hiding this comment.
Are you sure that this is the way that it is calculated?
I think that the dataset total size is the sum of the size of the files listed in the origDatablock
There was a problem hiding this comment.
If you see this line for example on the creation of origDatablock: https://github.com/SciCatProject/scicat-backend-next/blob/master/src/datasets/datasets.controller.ts#L1945
Or this line in the update: https://github.com/SciCatProject/scicat-backend-next/blob/master/src/datasets/datasets.controller.ts#L2101
We can see that the size it is used and not the sum of the files listed.
There was a problem hiding this comment.
OK. You are correct.
Let's resolve this conversation, and bring the discussion to the collaborators
migrations/20250423114619-populate-overwritten-datasets-size.js
Outdated
Show resolved
Hide resolved
|
@nitrosx let me know what are your final thoughts about this one. As I know you left some comments before. |
…d numberOfFilesArchived were overwritten
Junjiequan
force-pushed
the
SWAP-4629-fix-affected-dataset-with-size-0
branch
from
bc2a991 to
1e24dae
Compare
Description
This PR aims to provide a migration script for datasets properties that were overwritten by a bug that was found and fixed in the code.
Motivation
size,numberOfFiles,packedSizeandnumberOfFilesArchivedwere all overwritten by a bug in the code and those needed to be fixed.Fixes
Changes:
Tests included
Documentation
official documentation info