Skip to content

fix: scientific metadata query and dto validation issues #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
abdimo101 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: scientific metadata query and dto validation issues #2414

abdimo101 wants to merge 2 commits into from

Conversation

@abdimo101
Copy link
Member

@abdimo101 abdimo101 commented Dec 15, 2025 •
edited
Loading

Description

This PR removes .toLowerCase() from mapScientificQuery and adds scientificMetadataValid to UpdateDatasetDto.

Motivation

  • Filter search fails using for example "Type of Cleaning" because the query converted the metadata key to be lowercase.
  • Trying to update a dataset returns a 400 error because scientificMetadataValid was not added to the DTO.

Fixes

  • Bug fixed (#X)

Changes:

  • changes made

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@abdimo101 abdimo101 requested a review from a team as a code owner December 15, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitrosx nitrosx Awaiting requested review from nitrosx

@sofyalaski sofyalaski Awaiting requested review from sofyalaski

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@abdimo101 @totopoloco