Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata schema configuration and new logic #44

Merged
merged 12 commits into from
Jul 16, 2024
Merged

Conversation

nitrosx
Copy link
Member

@nitrosx nitrosx commented Jul 15, 2024

This PR introduces the new metadata schema configuration and the code to select the applicable one and to define the configured values

@nitrosx nitrosx added enhancement New feature or request help wanted Extra attention is needed labels Jul 15, 2024
@nitrosx nitrosx requested a review from YooSunYoung July 15, 2024 09:04
@YooSunYoung
Copy link
Contributor

YooSunYoung commented Jul 15, 2024

I think what you trying to do is clear enough in the code. Maybe just some wrapping needed, like extracting parts of code to a function and etc.
Are you going to finish it so that it passes all the checks as well or do you want me to take it over...? @nitrosx

@YooSunYoung YooSunYoung enabled auto-merge July 16, 2024 14:46
@YooSunYoung YooSunYoung merged commit 4503711 into main Jul 16, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the schema_selector branch July 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants