-
-
Notifications
You must be signed in to change notification settings - Fork 40
Optimal control interface #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ErikQQY
wants to merge
7
commits into
master
Choose a base branch
from
qqy/optimal_control
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+483
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark ResultsClick to check benchmark results
|
Comment on lines
419
to
+420
| @views function __mirk_loss!(resid, u, p, y, pt::TwoPointBVProblem, bc!::Tuple{BC1, BC2}, | ||
| residual, mesh, cache, _, trait::DiffCacheNeeded) where {BC1, BC2} | ||
| residual, mesh, cache, _, trait::DiffCacheNeeded, constraint::Val{false}) where {BC1, BC2} |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @views function __mirk_loss!(resid, u, p, y, pt::TwoPointBVProblem, bc!::Tuple{BC1, BC2}, | |
| residual, mesh, cache, _, trait::DiffCacheNeeded) where {BC1, BC2} | |
| residual, mesh, cache, _, trait::DiffCacheNeeded, constraint::Val{false}) where {BC1, BC2} | |
| @views function __mirk_loss!( | |
| resid, u, p, y, pt::TwoPointBVProblem, bc!::Tuple{BC1, BC2}, residual, mesh, | |
| cache, _, trait::DiffCacheNeeded, constraint::Val{false}) where {BC1, BC2} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #336
The current implementation concatenates the inequality/equality(the upper part) and the loss function([loss_bc; loss_collocation] as the lower part) as the constraints in OptimizationProblem. The Jacobian is handled by concatenating the Jacobian of inequality constraints(the upper square matrix) and the Jacobian of the loss function ([jac_loss_bc; jac_loss_collocation] as the lower rectangular matrix), resulting in a
(N*M + length(bc_resid_prototype) + length(f_prototype)*(N-1)) x (N*M)Jacobian. Then the Jacobian is, upper part: banded matrix; lower part: almost banded matrix.There are some weird issues with formulating the state variables and control variables, which may prevent the solver from finding an optimal solution. I’ll see what’s going wrong here.
Some TODOs:
uconsandlconshandling. More friendly information on choosinguconsandlconsshould be provided to users.