Skip to content

Fix CI #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix CI #1339

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99e91ea
Fix hybrid test failures
devmotion Nov 12, 2025
731cd2b
try to fix mtk structure indexing test
isaacsas Nov 12, 2025
5e4ab1a
mark test broken
isaacsas Nov 12, 2025
e4d9a5e
Check if docs can be built with [email protected]
devmotion Nov 13, 2025
78c1bd8
More bounds
devmotion Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/simulation_and_solving/hybrid_models.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ let
Nsims = 4000
for n in 1:Nsims
sol = solve(jprob, Tsit5(); saveat = tspan[2], seed)
@test sol.retcode == ReturnCode.Terminated
@test SciMLBase.successful_retcode(sol)
Xsamp += sol[1, end]
seed += 1
end
Expand Down
2 changes: 1 addition & 1 deletion test/upstream/mtk_structure_indexing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ begin
sint = init(sprob, ImplicitEM(); save_everystep = false)
jint = init(jprob, SSAStepper())
nint = init(nprob, NewtonRaphson(); save_everystep = false)
@test_broken ssint = init(ssprob, DynamicSS(Tsit5()); save_everystep = false) # https://github.com/SciML/SciMLBase.jl/issues/660
Copy link
Member

@isaacsas isaacsas Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TorkelE this doesn't return a boolean or error, so the test is not broken. I assume you meant this as a flag that there is an issue, but it seems to work now. Note though that ssint is not used anymore throughout the tests, so nothing is really being tested for it now beyond init.

Copy link
Member

@TorkelE TorkelE Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fine for 16 months, so I presume that something has changed underneath. I will update to ... false # ..., which should make things run for now. Then when we do the MTK fixes I will go through all of the changes and implications proiperly again.

ssint = init(ssprob, DynamicSS(Tsit5()); save_everystep = false)
integrators = [oint, sint, jint, nint]

# Creates solutions.
Expand Down
Loading