Add BSpline interpolation #20
Conversation
|
I will take a look at it today |
sathvikbhagavan
left a comment
sathvikbhagavan
left a comment
There was a problem hiding this comment.
LGTM! This implementation is much more intuitive. I will try to adapt this in DataInterpolations.jl
|
@sathvikbhagavan the docs keep failing on main, any idea why? |
|
It looks like a permission issue for the github action to deploy, probably needs some token configuration - https://github.com/SciML/NDInterpolations.jl/actions/runs/14524592134/job/40753243037#step:6:86 cc: @ChrisRackauckas |
|
Someone needs to setup the keys: https://documenter.juliadocs.org/stable/man/hosting/#travis-ssh any admin has access for it. I might not get to it till next weekend (since it's harder to do this on Windows, need to switch machines 😅 ) but have this email to snooze to then if no one picks it up |
It works now 🥳 |
Fixes #15.
@SciML/numerical-utilities who wants to take up the review for this? It's a good introduction into the
NDInterpolations.jlAPI and internals. Please feel free to comment on anything in this early stage of development.The B-Spline basis function evaluation implemented here (see
get_basis_function_values) could be adapted forDataInterpolations.jlto help with SciML/DataInterpolations.jl#419. See also the discussion there on the differences in implementation.