Add JET.jl static analysis tests #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type stability tests using JET.jl to validate: - GPU algorithm constructors (GPUTsit5, GPUVern7, GPUVern9, etc.) - SDE algorithm constructors (GPUEM, GPUSIEA) - Implicit algorithm constructors (GPURosenbrock23, GPURodas4, etc.) - Ensemble algorithm constructors (EnsembleCPUArray) - alg_order function type stability - diffeqgpunorm utility function type stability The package is already well-typed with extensive use of type parameters and where clauses. These tests provide ongoing validation of type stability for key entry points. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added
test/jet_tests.jlwith@test_optchecks for:alg_orderfunction type stabilitydiffeqgpunormutility function type stabilityAdded JET to test dependencies in
test/Project.tomlAdded JET test testset to
test/runtests.jlJET Analysis Observations
The package already has excellent type annotations with extensive use of:
whereclause constraintsJET's report about "Couldn't find a single matching method for the signature" for integrator constructors are not actual bugs - they're related to how JET interprets parametric struct constructors where
IIP::Boolis resolved at construction time through theinitfunctions rather than being passed directly.Test plan
cc @ChrisRackauckas
🤖 Generated with Claude Code