Performance improvements: fix Julia 1.12 compat and remove duplicate k1 computation #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AlgTypetype parameter in stiff integrator callable functions by moving definitions after struct definitionsGPUVern7andGPUVern9fixed-step integrators where k1 was computed twice per step (Vern7/9 are not FSAL methods, so this was unnecessary work)Performance Impact
f()evaluation per stepBenchmark Results (JLArrays backend, 1000 trajectories)
Test Plan
Changes
src/ensemblegpukernel/integrators/stiff/types.jl- Move callable andu_modified!definitions after struct definitions to fix Julia 1.12 type parameter issuesrc/ensemblegpukernel/perform_step/gpu_vern7_perform_step.jl- Remove dead code that computed k1 twicesrc/ensemblegpukernel/perform_step/gpu_vern9_perform_step.jl- Remove dead code that computed k1 twicetest/alloc_tests.jl- Add allocation tests for core functionstest/runtests.jl- Add allocation test grouptest/Project.toml- Add AllocCheck dependencycc @ChrisRackauckas
🤖 Generated with Claude Code