Add missing maxthreads method for JLBackend #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JLArraysExt extension was missing the `maxthreads` method for `JLBackend`, which caused `EnsembleGPUArray` to fail when used with JLArrays because `workgroupsize` calls `maxthreads(backend)`. This adds the `maxthreads` method consistent with other backend extensions (CUDA, AMDGPU, Metal, oneAPI, OpenCL) which all define `maxthreads(::Backend) = 256`. This fixes JLArray interface compliance for EnsembleGPUArray. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
maxthreadsmethod forJLBackendin the JLArrays extensionEnsembleGPUArraycompatibility with JLArraysProblem
The
JLArraysExtextension was missing themaxthreadsmethod forJLBackend. When usingEnsembleGPUArraywith JLArrays, the code callsworkgroupsize(backend, n)which in turn callsmaxthreads(backend). Without this method defined forJLBackend, users got:Solution
Added
DiffEqGPU.maxthreads(::JLBackend) = 256to the JLArrays extension, consistent with all other backend extensions (CUDA, AMDGPU, Metal, oneAPI, OpenCL) which all define this method with value 256.Testing
EnsembleGPUArraynow works correctly with JLArraysEnsembleGPUKernelcontinues to work with JLArraysTest Plan
GROUP=JLArrayscc @ChrisRackauckas
🤖 Generated with Claude Code