Expand JET.jl static analysis test coverage #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly expand the JET.jl test suite to cover more of the package's key functionality: - Add tests for implicit algorithm constructors with explicit autodiff settings - Add tests for all implicit algorithm orders (Rosenbrock23, Rodas4, Rodas5P, Kvaerno3, Kvaerno5) - Add tests for alg_autodiff function - Expand diffeqgpunorm tests to cover Float64, Complex, and ForwardDiff.Dual types - Add tests for make_prob_compatible with ODEProblem - Add comprehensive tests for integrator initialization (both fixed-step and adaptive) for all algorithm types - Add tests for Butcher tableau type stability (Vern7, Vern9, Rodas4, Rodas5P, Kvaerno3, Kvaerno5) - Add tests for adaptive controller cache type stability The expanded test suite now includes 75 JET tests (up from 19), ensuring better coverage of type stability throughout the package. Also add SciMLBase to test dependencies (needed for CallbackSet in tests). Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly expands the JET.jl test suite to improve static analysis coverage:
alg_order)alg_autodifffunction for all implicit solversdiffeqgpunormwith Float64, Complex, and ForwardDiff.Dual typesmake_prob_compatiblewith ODEProblemJET Analysis Summary
I ran
JET.report_package("DiffEqGPU")and analyzed key functions. The package is already well-typed:diffeqgpunorm,make_prob_compatible,alg_autodiff, etc.) are type-stableinitfunctions are type-stableSome false positives were identified (related to empty tuple indexing and callback
nothingchecks) that are properly guarded at runtime but JET cannot fully reason about.Test plan
Changes
test/jet_tests.jl- Significantly expanded JET test coveragetest/Project.toml- Added SciMLBase as test dependency (needed for CallbackSet in tests)🤖 Generated with Claude Code
cc @ChrisRackauckas