This repository was archived by the owner on Dec 30, 2025. It is now read-only.
Improve explicit imports hygiene#6
Merged
ChrisRackauckas merged 1 commit intoSciML:mainfrom Dec 29, 2025
Merged
Conversation
- Remove unused runtime dependencies (ModelingToolkit, NonlinearSolve, QuasiMonteCarlo, SparseArrays, Symbolics) - Make LinearAlgebra imports explicit (norm, I) - Remove broken/incomplete code from utils.jl - Clean up test dependencies, remove unused packages - Make test imports more explicit where possible - Add ExplicitImports.jl tests to verify import hygiene Files modified: - Project.toml: Reduced to only LinearAlgebra dependency - src/FastSolvers.jl: Explicit imports from LinearAlgebra - src/utils.jl: Removed broken sample_collocation_points function - test/Project.toml: Added ExplicitImports, removed unused deps - test/runtests.jl: Made imports more explicit - test/explicit_imports.jl: New file for CI import checks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
norm,I)utils.jl(thesample_collocation_pointsfunction referenced undefinedbcsvariable and usedSymbolicUtils.BasicSymbolicwithout importing)Files modified
Project.toml: Reduced to only LinearAlgebra dependencysrc/FastSolvers.jl: Explicit imports from LinearAlgebrasrc/utils.jl: Removed brokensample_collocation_pointsfunctiontest/Project.toml: Added ExplicitImports, removed unused depstest/runtests.jl: Made imports more explicittest/explicit_imports.jl: New file for CI import checksTest plan
check_no_implicit_imports,check_no_stale_explicit_imports)cc @ChrisRackauckas
🤖 Generated with Claude Code