This repository was archived by the owner on Dec 30, 2025. It is now read-only.
Improve static analysis and add JET tests#8
Open
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
Open
Improve static analysis and add JET tests#8ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:mainfrom
Conversation
- Fix undefined BVP/IVP exports by adding type aliases for BVPSolver/IVPSolver - Constrain kernel type parameters to Real (T <: Real) for better static analysis - Add JET.jl test suite with @test_opt and @test_call for type stability verification - All kernel functions pass JET analysis with no type instabilities 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const BVP = BVPSolverandconst IVP = IVPSolvertype aliases to fix the broken exports in the moduleReal(T <: Real) for better static analysis and early error detection@test_optand@test_callmacros for type stability verificationChanges
Bug fix
The package was exporting
BVPandIVPbut these names were not defined - onlyBVPSolverandIVPSolverexisted. Added type aliases to fix this.Static analysis improvements
T <: Realconstraint toSquaredExponentialKernel{T}andMatern52Kernel{T}New tests
Added
test/jet.jlwith:@test_opttests for type stability on scalar and vector inputs@test_calltests to verify no errors in FastSolvers module functionsTest plan
Pkg.test()locally - all tests passcc @ChrisRackauckas
🤖 Generated with Claude Code