Improve explicit imports hygiene #12
Merged
+15
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert implicit imports to explicit imports in FiniteVolumeMethod1D.jl - Add ExplicitImports.jl tests to CI - Update Project.toml and test/Project.toml with ExplicitImports dependency Changes made: - src/FiniteVolumeMethod1D.jl: Changed from bare `using` to explicit imports: - `using CommonSolve: CommonSolve, solve` - `using SciMLBase: SciMLBase, CallbackSet, DiscreteCallback, ODEFunction, ODEProblem` - `using SparseArrays: sparse` - test/explicit_imports.jl: New test file with ExplicitImports checks - test/runtests.jl: Added Explicit Imports test suite 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Source Code (src/FiniteVolumeMethod1D.jl)
Changed from bare
usingstatements to explicit imports:using CommonSolve: CommonSolve, solveusing SciMLBase: SciMLBase, CallbackSet, DiscreteCallback, ODEFunction, ODEProblemusing SparseArrays: sparseTest Infrastructure
test/explicit_imports.jlwith ExplicitImports checks:check_no_implicit_imports(FiniteVolumeMethod1D)check_no_stale_explicit_imports(FiniteVolumeMethod1D)test/runtests.jlto include Explicit Imports test suiteTest plan
cc @ChrisRackauckas
🤖 Generated with Claude Code