Skip to content

Comments

Fix CI AD tests#319

Merged
ChrisRackauckas merged 15 commits intoSciML:masterfrom
AstitvaAggarwal:dev
Feb 18, 2026
Merged

Fix CI AD tests#319
ChrisRackauckas merged 15 commits intoSciML:masterfrom
AstitvaAggarwal:dev

Conversation

@AstitvaAggarwal
Copy link
Member

fix for https://github.com/SciML/Integrals.jl/actions/runs/22019774579/job/63626939880?pr=308

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AstitvaAggarwal
Copy link
Member Author

@ChrisRackauckas gtm?

@AstitvaAggarwal
Copy link
Member Author

AstitvaAggarwal commented Feb 17, 2026

Fixed everything. Ill remove the added increment_and_get_rdata dispatches once chalk-lab/Mooncake.jl#997 is merged back at Mooncake.jl (either here or in a seperate PR), feel free to merge early if you want CI to pass.

Thanks for the reviews!

@ChrisRackauckas
Copy link
Member

Okay so we wait upstream a bit to get the patch into Mooncake, remove that last bit, then merge.

@ChrisRackauckas
Copy link
Member

bump the lower bound?

@ChrisRackauckas ChrisRackauckas merged commit ca32340 into SciML:master Feb 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants