Skip to content

Remove SparseArrays hard dep #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

@oscardssmith do you know what's going on here?

@oscardssmith
Copy link
Member

no idea. That's very odd. The syntax looks correct to me...

@efaulhaber
Copy link

Could this be related to our CI failures on Windows and macOS with Julia 1.10?

      Testing TrixiParticles
      Status `/private/var/folders/2s/h6hvv9ps03xgz_krkkstvq_r0000gn/T/jl_lQhyGj/Project.toml`
  [336ed68f] CSV v0.10.15
  [13f3f980] CairoMakie v0.13.1
  [a93c6f00] DataFrames v1.7.0
  [38e38edf] GLM v1.9.0
  [c27321d9] Glob v1.3.1
  [682c06a0] JSON v0.21.4
  [1dea7af3] OrdinaryDiffEq v6.91.0
  [91a5bcdd] Plots v1.40.9
  [f517fe37] Polyester v0.7.16
  [1fd47b50] QuadGK v2.11.2
  [66699cd8] TrixiParticles v0.2.7-dev `~/work/TrixiParticles.jl/TrixiParticles.jl`
  [37e2e46d] LinearAlgebra
  [de0858da] Printf
  [9a3f8284] Random
  [8dfed614] Test
      Status `/private/var/folders/2s/h6hvv9ps03xgz_krkkstvq_r0000gn/T/jl_lQhyGj/Manifest.toml`
ERROR: LoadError: KeyError: key "SparseArrays" not found

CC @svchb

@devmotion
Copy link
Member

Could this be related to our CI failures on Windows and macOS with Julia 1.10?

Maybe that's an instance of JuliaLang/Pkg.jl#4018

@efaulhaber
Copy link

There is nothing ]devd. This is a clean environment in CI. Here is a run that failed:
https://github.com/trixi-framework/TrixiParticles.jl/actions/runs/13334236066/job/37326563116?pr=584

@devmotion
Copy link
Member

devmotion commented Feb 18, 2025

There is nothing ]devd

TrixiParticles is devd in the CI run. Maybe that's sufficient to trigger the bug, maybe not. Another possibly related issue is JuliaLang/Pkg.jl#3947.

@ChrisRackauckas
Copy link
Member Author

Could this be related to our CI failures on Windows and macOS with Julia 1.10?

Well this is just on the PR branch, and this branch isn't merged, so it shouldn't cause anything downstream.

@svchb
Copy link

svchb commented Feb 18, 2025

Erik is referring to a common bug, for example, in Pkg.jl.

@devmotion devmotion mentioned this pull request Feb 25, 2025
@devmotion
Copy link
Member

Possibly the problem with this PR is that it does not add SparseArrays as additional trigger to the extensions that depend on it. With these additional changes, the Pkg error does not show up anymore: #584

@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-2 branch February 28, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants