Skip to content

fix pattern_changed #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

fix pattern_changed #591

merged 3 commits into from
Mar 28, 2025

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 27, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

The test

@testset "Sparse matrix (check pattern_changed)" begin
    n = 4
    A = spdiagm(1 => ones(n - 1), 0 => fill(2.0, n), -1 => ones(n - 1))
    b = rand(n)
    linprob = @inferred LinearProblem(A, b)
    alg = @inferred LUFactorization()
    linsolve = @inferred init(linprob, alg)
    linres = @inferred solve!(linsolve)
end

I added failed before with the error

Error During Test at REPL[52]:1
  Got exception outside of a @test
  ArgumentError: pattern of the matrix changed
  Stacktrace:
    [1] umferror(status::Int32)
      @ SparseArrays.UMFPACK
[...]

I already bumped the patch version to make it easier for you to release this bug fix.

@ChrisRackauckas
Copy link
Member

Load errror

@ranocha
Copy link
Member Author

ranocha commented Mar 27, 2025

Sorry, should be fixed

@ranocha
Copy link
Member Author

ranocha commented Mar 28, 2025

The CI error in

  Expression: isempty(stderr_content)
   Evaluated: isempty("┌ Warning: The GPUCompiler `compile` API does not take keyword arguments anymore. Use CompilerConfig instead.\n│   caller = (::AllocCheck.var\"#22#26\"{GPUCompiler.CompilerJob{GPUCompiler.NativeCompilerTarget, AllocCheck.NativeParams}, Bool})(ctx::LLVM.Context) at compiler.jl:92\n└ @ AllocCheck ~/.julia/packages/AllocCheck/FZ8z1/src/compiler.jl:92\n")

in Tests / Tests (1, Core) / Tests - Core (pull_request) is not caused by this PR.

Same for the error

  LoadError: Did not find CodeInstance for GPUCompiler.CompilerJob{GPUCompiler.NativeCompilerTarget, AllocCheck.NativeParams}(MethodInstance for Main.var"##Static Arrays#236".var"##__solve_no_alloc#299"(::StaticArraysCore.SMatrix{5, 5, Float64, 25}, ::StaticArraysCore.SVector{5, Float64}, ::Nothing), CompilerConfig for GPUCompiler.NativeCompilerTarget, 0x0000000000007c4f).

in Tests / Tests (lts, Core) / Tests - Core (pull_request)

@ChrisRackauckas
Copy link
Member

oh oops I see.

@ChrisRackauckas ChrisRackauckas merged commit 03a444f into SciML:main Mar 28, 2025
21 of 30 checks passed
@JoshuaLampert
Copy link

Thanks for merging! Would you mind registering v3.7.1 (not v3.7.2 as currently in the Project.toml if I'm not misunderstanding something) so we get our CI fixed?

@JoshuaLampert
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants