Add LinearSolvePyAMG sub-library with PyAMG integration and tests#900
Open
AJ0070 wants to merge 3 commits intoSciML:mainfrom
Open
Add LinearSolvePyAMG sub-library with PyAMG integration and tests#900AJ0070 wants to merge 3 commits intoSciML:mainfrom
AJ0070 wants to merge 3 commits intoSciML:mainfrom
Conversation
Contributor
Author
|
I created a separate test group for PyAMG to prevent the extra setup time from installing Python and PyAMG from slowing down every Core CI job. If there is a better way to handle this, I would appreciate your thoughts @ChrisRackauckas. |
Member
|
No AI was used at all? |
Contributor
Author
|
Sorry, I missed it. I have added it now and will keep it in mind to include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Changes
### LinearSolvePyAMG.jlsection@static if isdefined(...)test block.CondaPkg/Implemented as a sub-library (like
lib/LinearSolveAutotune/) rather than a weak dependency because PyAMG is not in the Julia General registry.Resolves #372
AI disclosure: used claude and gemini to help in replicating structure of LinearSolveAutotune in LinearSolvePyAMG, adding comments and refactoring documentation.