Skip to content

fix: fix incorrect namespacing of DelayParentScope variables in collect_scoped_vars! #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025

Conversation

AayushSabharwal
Copy link
Member

No description provided.

@AayushSabharwal AayushSabharwal marked this pull request as draft April 3, 2025 14:42
@AayushSabharwal
Copy link
Member Author

Draft because it breaks Catalyst due to an incorrect interpretation of DelayParentScope's behavior when writing collect_scoped_vars!.

@AayushSabharwal
Copy link
Member Author

Catalyst test fixes SciML/Catalyst.jl#1214

@AayushSabharwal AayushSabharwal merged commit 2c11936 into SciML:master Apr 8, 2025
41 of 44 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-delayscope branch April 8, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants