fix: only examine RHS in equation_dependencies #4129
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Rebasing should fix tests. |
SebastianM-C
force-pushed
the
smc/eq_deps
branch
from
3d4d470 to
cc8f783
Compare
Member
|
This breaks the dependency analysis for jumps |
SebastianM-C
force-pushed
the
smc/eq_deps
branch
from
cc8f783 to
060627f
Compare
Symbolics@5fe7a2d6 added a `search_variables!` method for `Equation` that searches both LHS and RHS. This broke `equation_dependencies` which relies on finding only RHS dependencies. The original MTK behavior (from 2020, commit 3160770) explicitly only examined `eq.rhs`. This fix restores that behavior by passing `eq.rhs` directly instead of relying on the generic `Equation` method. Co-Authored-By: Claude Opus 4.5 <[email protected]>
SebastianM-C
force-pushed
the
smc/eq_deps
branch
from
060627f to
c51a60e
Compare
Member
Author
|
I updated the fix to only use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolics@5fe7a2d6 added a
search_variables!method forEquationthat searches both LHS and RHS. This brokeequation_dependencieswhich relies on finding only RHS dependencies.The original MTK behavior (from 2020, commit 3160770) explicitly only examined
eq.rhs. This fix restores that behavior by passingeq.rhsdirectly instead of relying on the genericEquationmethod.Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.