Avoid piracy in jump dependency traversal - #4907
Conversation
Keep jump-specific variable traversal behind a ModelingToolkitBase-owned helper instead of extending SymbolicUtils on JumpProcesses types. Add a regression test for the removed methods. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
|
CI baseline update: the two completed failures are both reproduced on unchanged
The PR-specific jump dependency tests and full local |
|
Additional clean-master CI baseline: the LTS benchmark job fails because |
|
Additional clean-master CI classification: the MTKBase compatibility-floor failure is identical on origin/master and is tracked separately in #4911. History analysis traces the stale Julia 1.10 |
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
SymbolicUtils.search_variables!methods on JumpProcesses-owned jump typesContext
A clean
origin/masterQA reproduction at731eff66b596fbc6bc36aff45b21bb2e81e1bddbreports 14 Aqua piracy methods: foursearch_variables!methods and ten oldertoexprmethods. This focused change removes the four jump-related methods. The remainingtoexprownership work is tracked in #4670.The existing narrow
SimpleNonlinearSolvestale-dependency allowance is unchanged. That dependency is used only byMTKBifurcationKitExtand must remain hard so loading BifurcationKit activates the extension.Local verification
--check --diffon all three changed files: passgit diff --check: passlib/ModelingToolkitBase/test/dep_graphs.jl: all testsets pass (1/1,22/22,3/3,1/1)GROUP=InterfaceIpackage test: 1,502 pass, 5 pre-existing broken, 1,507 total; package test passed in 48m04sAqua.test_piracies(ModelingToolkitBase): expected nonzero result containing exactly the ten pre-existingtoexprmethods and nosearch_variables!methodsCI baseline
The repository-wide Runic check fails on unchanged clean-master
lib/ModelingToolkitBase/src/problems/initializationproblem.jl. Exact local reproduction and the introducing commit are tracked in #4908. This PR does not mix that unrelated one-word formatting fix into the jump-piracy change.