qa: import names through owning modules - #4981
Merged
ChrisRackauckas merged 5 commits intoAug 17, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
codex/mtk-qa-owner-imports
branch
from
August 16, 2026 09:34
6cbfce4 to
2e43142
Compare
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
August 17, 2026 06:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until it has been reviewed by @ChrisRackauckas.
What changed
Import names through the modules that own them according to
Base.whichand the strict ExplicitImports owner checks:t_nounitsandD_nounitsfromModelingToolkitBase.unwrapthroughSymbolicUtils.scalarizeremains imported fromSymbolics, where it is public.This is a focused QA correctness fix. It does not change algorithms, precompile workloads, public API, or documentation.
Failure before
On this branch before the
scalarizecorrection:Verification after
With the correction applied:
The two remaining errors are the pre-existing analyzer limitation caused by the dynamic
include(pkgdir(ModelingToolkitBase, "src", "precompile.jl"))insrc/precompile.jl:no_implicit_importsandno_stale_explicit_importsreportUnanalyzableModuleException. This PR does not suppress or allow-list those failures.Additional checks:
typospassed on changed files.git diff --checkpassed.This is independent of the cross-reference work in #4980.