Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation build failure fixed #370

Merged
merged 6 commits into from
Mar 11, 2025
Merged

Conversation

matthew-kapp
Copy link
Contributor

@matthew-kapp matthew-kapp commented Mar 10, 2025

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

  • Currently the documentation building fails

    • This is caused by running the example DC motor with PI control
    • The error was fixed
    • The same outputs as on the public docs is created
    • Documentation building completes on my machine and here on Github CI
  • There are unfortunately many commits

    • In the end only one line on one file is changed
    • I attempted to fix the format checks as well, but this broke tests, so I reverted

@matthew-kapp matthew-kapp changed the title Documentation build failure fixed Documentation build and format check failures fixed Mar 11, 2025
@matthew-kapp matthew-kapp changed the title Documentation build and format check failures fixed Documentation build failure fixed Mar 11, 2025
@ChrisRackauckas ChrisRackauckas merged commit a17e8ea into SciML:main Mar 11, 2025
3 of 5 checks passed
@matthew-kapp matthew-kapp deleted the docs-fail branch March 11, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants