Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ref to non-existant p_int and fix format #372

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Drop ref to non-existant p_int and fix format #372

merged 2 commits into from
Mar 20, 2025

Conversation

ven-k
Copy link
Member

@ven-k ven-k commented Mar 20, 2025

Closes #354

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

@ven-k ven-k changed the title Drop non-existant refs to p_int and fix format Drop ref to non-existant p_int and fix format Mar 20, 2025
@ven-k ven-k marked this pull request as ready for review March 20, 2025 07:02
@ven-k
Copy link
Member Author

ven-k commented Mar 20, 2025

Failing tests are unrelated to the PR.

@ChrisRackauckas ChrisRackauckas merged commit b5b01b4 into SciML:main Mar 20, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No argument 'p_int' for HydraulicPort
2 participants
@ven-k @ChrisRackauckas