Fix flaky Lorenz System test with deterministic seed#1029
Open
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Open
Fix flaky Lorenz System test with deterministic seed#1029ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
ChrisRackauckas-Claude wants to merge 1 commit intoSciML:masterfrom
Conversation
The Lorenz System parameter estimation test in NNPDE2 was failing intermittently because the neural network weight initialization used a non-deterministic random seed, causing BFGS optimization to sometimes converge to bad local minima. Add Random.seed!(100) for reproducibility, consistent with other test items in this file. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
CI Results24/26 test jobs passed. The 2 failures are infrastructure issues, not test code issues:
All actual test groups pass:
Please re-run the failed jobs to confirm they're transient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Random.seed!(100)to the Lorenz System test to make neural network weight initialization deterministicdirect_function_tests.jlalready usesRandom.seed!)Problem
The
Lorenz Systemtest in NNPDE2 group was failing intermittently on CI. On the Feb 2 master CI run, all 26 jobs passed exceptTests (1.11, NNPDE2)which failed with:The BFGS optimizer converged to a bad local minimum because the random neural network weight initialization was non-deterministic.
Test plan
🤖 Generated with Claude Code