[WIP]Start experimenting with DI #31
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdalle
reviewed
Apr 10, 2024
|
@Vaibhavdixit02 DifferentiationInterface v0.2 is out, and we got rid of the bang-bang in favor of always mutating the provided storage. This will make all of our lives easier |
|
@Vaibhavdixit02 DI v0.3 is out, and it even removes the need for SparseDiffTools in the simplest cases. Take it for a spin! |
Vaibhavdixit02
force-pushed
the
expDI
branch
3 times, most recently
from
7f222bd to
edba721
Compare
This was referenced May 15, 2024
|
You need a more recent version of DI, at least 0.5.1 for Enzyme to work in second order and 0.5.2 for it to be fast. The tests are still running with 0.5.0. |
|
Come on, I run all tests against DI master locally depending on releases is for p******! 🤣 |
|
It seems the last tests were run 3 days ago, you closing and reopening has apparently not re-triggered CI |
|
Because of the merge conflict |
Enzyme v0.12 now requires that all inputs are marked with an activity, and so these need to manually be marked const.
|
Indeed you pushed a merge conflict at least in the project file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.