Skip to content

[WIP] SymbolicAnalysis integration #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 2, 2024
Merged

[WIP] SymbolicAnalysis integration #35

merged 10 commits into from
Jul 2, 2024

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@Vaibhavdixit02 Vaibhavdixit02 marked this pull request as draft April 11, 2024 14:49
@Vaibhavdixit02 Vaibhavdixit02 force-pushed the symanalysis branch 2 times, most recently from b6d3fd0 to 4ac3f4f Compare April 12, 2024 17:36
@ChrisRackauckas
Copy link
Member

@AayushSabharwal review the SII integration.

Copy link
Member

@AayushSabharwal AayushSabharwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming test failures are due to something else. I don't see anything that stands out as concerning

@Vaibhavdixit02 Vaibhavdixit02 marked this pull request as ready for review July 1, 2024 02:35
@Vaibhavdixit02 Vaibhavdixit02 merged commit 78e73af into main Jul 2, 2024
3 of 5 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the symanalysis branch July 2, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants