Skip to content

Remove AutoMTK constructor overload here #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Depends on SciML/ADTypes.jl#61

Fixes #55

@gdalle
Copy link
Contributor

gdalle commented Jun 7, 2024

AutoModelingToolkit is deprecated so I think the solution is to avoid relying on it altogether, not reintroduce it in ADTypes

@ChrisRackauckas
Copy link
Member

Well we should make the deprecation path actually correct. The issue is that the deprecation is not correct.

@ChrisRackauckas
Copy link
Member

Deprecation paths are all working here! Lots of work to be done, but that's a big win.

@ChrisRackauckas ChrisRackauckas merged commit 8585a73 into main Jun 7, 2024
4 of 6 checks passed
@ChrisRackauckas ChrisRackauckas deleted the remautomtkconstr branch June 7, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptimizationMTKExt.jl gets re-precompiled
3 participants