Fix Unitful.jl compatibility for stabilized RK methods #2976
+122
−48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unitful#2858 where stabilized RK methods (ESERK4, ESERK5, SERK2, ROCK2, ROCK4, RKC) failed when time was given as a Unitful quantitymaxeig!power iteration function inrkc_utils.jlmixed quantities with rate units[u]/[t]and state units[u], causing dimensional incompatibilityzhas rate units and multiply bydtwhen converting to state unitsDiffEqBase.value()to strip units fromdtanddtmaxwhen computing unitless eigenvalue estimatessqrt(abs(dt) * integrator.eigen_est)in perform_step to use unitlessdtvalueTest plan
Unitful#2858:🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.5 [email protected]