GPU Compatibility of QNDF and FBDF#3134
Closed
KeshavVenkatesh wants to merge 3 commits intoSciML:masterfrom
Closed
GPU Compatibility of QNDF and FBDF#3134KeshavVenkatesh wants to merge 3 commits intoSciML:masterfrom
KeshavVenkatesh wants to merge 3 commits intoSciML:masterfrom
Conversation
Member
|
Rebase onto master. |
2 tasks
ChrisRackauckas
added a commit
that referenced
this pull request
Mar 17, 2026
…mpat-rebased GPU Compatibility of QNDF and FBDF (rebased #3134)
Member
|
Rebased in #3155 and merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
I did not add new tests but existing tests under bdf_solvers.jl passed.
None
Yes
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I ran the test documented in the issue here and it ran fine
2.600186 seconds (6.02 M allocations: 322.647 MiB, 15.44% gc time, 97.52% compilation time)
7.793672 seconds (10.10 M allocations: 495.285 MiB, 2.02% gc time, 92.47% compilation time)
0.397909 seconds (413.27 k allocations: 22.173 MiB, 17.23% gc time, 96.54% compilation time)
0.603914 seconds (1.34 M allocations: 52.057 MiB, 57.27% compilation time)
Euler: retcode=Success
Rodas5: retcode=Success
TRBDF2: retcode=Success
ROCK2: retcode=Success
QNDF: retcode=Unstable
FBDF: retcode=Success
I was also able to run the bdf_solvers.jl and it ran fine. I had to add hint for tolerance and max number of tries.