Move nonfulldiagonal_sparse test to OrdinaryDiffEqDifferentiation#3158
Merged
ChrisRackauckas merged 4 commits intoSciML:masterfrom Mar 18, 2026
Merged
Conversation
Add a separate "Sparse" test group for OrdinaryDiffEqDifferentiation that uses its own environment (test/sparse/Project.toml) to handle the ComponentArrays dependency. The autosparse_detection and sparsediff tests remain in the global suite because SparseConnectivityTracer 0.6 conflicts with PreallocationTools in the current registry compat. This is a known ecosystem issue that will resolve when PreallocationTools updates its SparseConnectivityTracer compat bounds. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ackages Move MTK tests from the global test suite to subpackage-specific ModelingToolkit test groups with separate environments: - jacobian_tests.jl → OrdinaryDiffEqDifferentiation (ModelingToolkit group) - nlstep_tests.jl → OrdinaryDiffEqNonlinearSolve (ModelingToolkit group) - preconditioners.jl → OrdinaryDiffEqNonlinearSolve (ModelingToolkit group) - dae_initialize_integration.jl → OrdinaryDiffEqNonlinearSolve (ModelingToolkit group) Each subpackage gets a test/modelingtoolkit/ directory with its own Project.toml (similar to test/ad/ and test/downstream/ patterns in the main test suite) and a test_groups.toml entry for CI matrix generation. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace ModelingToolkit.Symbolics.jacobian_sparsity with a direct sparsity pattern construction for the 2D Brusselator. The test is about preconditioner performance with Krylov solvers, not MTK. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The import was a leftover from the original file and causes an error on Julia LTS (1.10) since dolinsolve is not exported from OrdinaryDiffEqCore. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonfulldiagonal_sparse.jlfrom the global test suite (InterfaceIII) toOrdinaryDiffEqDifferentiationas a "Sparse" test grouptest/sparse/Project.toml) to handle the ComponentArrays dependency without polluting the main subpackage test depstest_groups.tomlto OrdinaryDiffEqDifferentiation to enable CI matrix generation for Core, QA, and Sparse groupsWhy a separate test env?
ComponentArrays and SparseConnectivityTracer conflict with PreallocationTools (via OrdinaryDiffEqNonlinearSolve) in the current registry compat bounds. The separate env pattern (same as
test/downstream/,test/ad/) sidesteps this by usingOrdinaryDiffEqas a single source dep.Not moved (PreallocationTools <-> SparseConnectivityTracer 0.6 registry compat gap):
autosparse_detection_tests.jl— needs SparseConnectivityTracer 0.6sparsediff_tests.jl— needs SparseConnectivityTracer 0.6These can be moved once PreallocationTools updates its SparseConnectivityTracer compat in the General registry.
Test plan
Pkg.test()withODEDIFFEQ_TEST_GROUP=Sparse🤖 Generated with Claude Code