Clean up orphaned test files in StochasticDiffEq#3205
Merged
ChrisRackauckas merged 4 commits intoSciML:masterfrom Mar 23, 2026
Merged
Clean up orphaned test files in StochasticDiffEq#3205ChrisRackauckas merged 4 commits intoSciML:masterfrom
ChrisRackauckas merged 4 commits intoSciML:masterfrom
Conversation
Delete 12 duplicate test files whose canonical versions now live in StochasticDiffEqWeak and StochasticDiffEqROCK subpackages. Delete 2 additional files: units_tests.jl (commented-out stub) and oval2_single.jl (benchmark script, not a test). Add 5 previously orphaned but working test files to appropriate test groups in runtests.jl: - aliasing_tests.jl → Interface1 - noncommutative_tests.jl → AlgConvergence - unrolled_comparison_tests.jl → AlgConvergence - sparsediff_tests.jl → Interface3 - split_tests.jl → AlgConvergence2 Fixes SciML#3163 Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…gence test as broken split_tests.jl: SplitEM vs EM noise sharing comparison produces different trajectories — pre-existing breakage, not a regression from this PR. noncommutative_tests.jl:112: RKMilGeneral(p=true) weak convergence estimate is unreliable with only 100 trajectories on this non-commutative problem. Strong convergence was already @test_broken; mark weak convergence the same. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SRI() and SRIW1() produce completely different trajectories with the same seed — all 4 assertions fail. Pre-existing breakage, not a regression. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3163 — cleans up orphaned test files in
lib/StochasticDiffEq/test/left behind after the SDE subpackage split (PR #3154).Deleted 14 files:
StochasticDiffEqWeakandStochasticDiffEqROCKsubpackages:weak_convergence/: PL1WM.jl, SIE_SME.jl, W2Ito1.jl, iri1_weak.jl, srk_weak_diagonal_final.jl, srk_weak_final.jl, srk_weak_final_non_diagonal.jl, weak_strat.jl, weak_strat_non_diagonal.jl, weak_srockc2.jladaptive/: sde_weak_adaptive.jl, sde_weak_brusselator_adaptive.jlAdded 5 orphaned tests to test groups in runtests.jl:
aliasing_tests.jl→ Interface1 (tests SDE/RODE alias keyword handling)noncommutative_tests.jl→ AlgConvergence (convergence tests for noncommutative noise solvers)unrolled_comparison_tests.jl→ AlgConvergence (verifies SRI ≡ SRIW1 for default tableaux)sparsediff_tests.jl→ Interface3 (sparse Jacobian prototype with SKenCarp)split_tests.jl→ AlgConvergence2 (SplitSDE convergence with SKenCarp)Test plan
.jlfiles inlib/StochasticDiffEq/test/🤖 Generated with Claude Code