Make calculate_residuals! consistently return nothing#3243
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Mar 27, 2026
Merged
Conversation
All in-place calculate_residuals! methods now return nothing consistently. Previously two methods returned nothing while others returned the output array or the broadcast result, which was inconsistent with the in-place mutation convention used throughout DiffEqBase. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calculate_residuals!methods in DiffEqBasenothing, one returned the broadcast result, and one returnedout— now all consistently returnnothingNo callers capture the return value of
calculate_residuals!anywhere in the monorepo, so this is a safe change.Test plan
🤖 Generated with Claude Code