Remove Bool verbose compatibility path for v7#3244
Merged
ChrisRackauckas merged 1 commit intoSciML:v7from Mar 27, 2026
Merged
Conversation
…nge) Replace the Bool->DEVerbosity conversion with an ArgumentError that directs users to use DEVerbosity() or SciMLLogging presets (Standard(), None(), etc.). Changes: - OrdinaryDiffEqCore: _process_verbose_param(::Bool) now throws ArgumentError - StochasticDiffEqCore: default verbose changed from true to Standard(), Bool branch in _sde_init throws ArgumentError - DelayDiffEq: Bool branch in __init throws ArgumentError - Updated tests to use DEVerbosity(None()) instead of verbose=false - Added tests verifying Bool verbose is rejected Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boolcompatibility path for theverbosekeyword argument, making it a v7 breaking changeverbose=trueandverbose=falsenow throwArgumentErrorwith a message directing users to useDEVerbosity()or SciMLLogging presets (Standard(),None(), etc.)verboseinStochasticDiffEqCorefromtruetoStandard()Changes
lib/OrdinaryDiffEqCore/src/verbosity.jl:_process_verbose_param(::Bool)now throwsArgumentErrorinstead of silently convertinglib/StochasticDiffEqCore/src/solve.jl: Defaultverbosechanged fromtruetoStandard(); Bool branch throwsArgumentErrorlib/DelayDiffEq/src/solve.jl: Bool branch throwsArgumentErrorverbose = falsein solve/init calls replaced withDEVerbosity(None()); new tests verify Bool is rejectedCloses #2310
Test plan
test/interface/verbosity.jlpasses (140/140 tests)🤖 Generated with Claude Code