Replace blanket @reexport with explicit exports#3264
Merged
ChrisRackauckas merged 2 commits intoSciML:v7from Mar 27, 2026
Merged
Replace blanket @reexport with explicit exports#3264ChrisRackauckas merged 2 commits intoSciML:v7from
ChrisRackauckas merged 2 commits intoSciML:v7from
Conversation
Remove all @reexport usage and explicitly list only the ODE-relevant symbols that OrdinaryDiffEq should export. This avoids leaking unrelated SciMLBase exports like BVProblem, IntegralProblem, etc. - Remove Reexport dependency entirely - Replace @reexport using OrdinaryDiffEqCore with explicit imports - Replace @reexport using OrdinaryDiffEqDefault with explicit imports - Export only ODE problem types, callbacks, algorithms, and utilities Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Per @oscardssmith review: - Remove DiscreteProblem/DiscreteFunction (not ODE-specific) - Remove Ensemble algorithm types (EnsembleThreads etc.) - Remove internal utilities (du_cache, full_cache, u_cache, etc.) - Remove ODEAliasSpecifier, addsteps!, savevalues!, isfsal, ode_interpolant - Remove CompositeAlgorithm, AutoSwitch, init types, controllers - Remove DefaultImplicitODEAlgorithm - Add ADTypes exports: AutoForwardDiff, AutoFiniteDiff, AutoSparse Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
we should also search the rest of the packages here for reexport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @oscardssmith's review on #3249: remove all
@reexportusage and explicitly list only the ODE-relevant symbols.Reexportdependency entirely@reexport using OrdinaryDiffEqCorewith explicitusing+export@reexport using OrdinaryDiffEqDefaultwith explicitusing+exportODEProblem,ODEFunction, callbacks,ReturnCode, etc.)BVProblem,IntegralProblem,OptimizationProblem, or other non-ODE SciMLBase typesTest plan
BVProblemcorrectly not exportedsolve(prob, Tsit5())works end-to-end🤖 Generated with Claude Code