Open
Conversation
MartinuzziFrancesco
requested changes
Mar 25, 2026
| # rand_hyper | ||
|
|
||
| ```@docs | ||
| # rand_hyper |
|
|
||
| ## Keyword arguments | ||
|
|
||
| - `d`: Dimension of the hyperbolic manifold. |
Collaborator
There was a problem hiding this comment.
better to avoid single letter kwargs
Collaborator
|
Thanks for looking into this! The implementation seems to be ok, although I will need to double check against the python code. There are a couple of minor changes to tackle in the meantime, I left some comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303
Checklist
Implementation Details
The
hyper_initfunction executes the following steps:Refactoring & Helper Functions
To keep
hyper_initclean, the logic is modularized into three helper functions (taking inspiration from the original Proof of Concept):hyperbolic_distance_poincaresample_poincare_pointstopk_row_sparsifyMathematical Assumptions
A simplifying assumption is used when sampling the radius$\rho$ from the Poincaré ball. To match the approximation used in the PoC, the radius is sampled linearly:
Instead of the exact inverse transform sampling method:
Questions:
kwargsneed more clarity or better naming conventions, I am happy to adjust them.