Fix StiffODE benchmark by removing broken GeometricIntegratorsDiffEq dependency #1445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the StiffODE benchmark by removing the broken
GeometricIntegratorsDiffEqdependency.Problem
GeometricIntegratorsDiffEqfails to precompile with Julia 1.11 due to type errors in the underlyingGeometricIntegratorspackage:Root Cause
The
GeometricIntegratorsDiffEqdependency was not actively used in the StiffODE benchmarks. All usages were commented out with notes indicating it has not been upgraded to modern Julia versions (see comments in ROBER.jmd line 37: "GeometricIntegratorsDiffEq has not upgraded to Julia 1.0").Changes
GeometricIntegratorsDiffEqfrom StiffODEProject.tomldepsGeometricIntegratorsDiffEqfrom StiffODEProject.tomlcompatManifest.tomlfor StiffODE benchmarkTesting
Files Checked
All usages of
GeometricIntegratorsDiffEqin StiffODE benchmarks are commented out:StiffODE/VanDerPol.jmd:48:#using GeometricIntegratorsDiffEqStiffODE/ROBER.jmd:43:#using GeometricIntegratorsDiffEqStiffODE/Hires.jmd:59:#using GeometricIntegratorsDiffEqStiffODE/Orego.jmd:46:#using GeometricIntegratorsDiffEqStiffODE/Pollution.jmd:228:#using GeometricIntegratorsDiffEqcc @ChrisRackauckas