Fix typos and variable name errors in benchmarks #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix RC Circuit benchmark: correct variable name from deeref to daeref (fixes issue SciML#1034) - Fix AstroChem nelson benchmark: correct pallete to palette - Fix NonStiffODE enright_pryce: correct orginal to original - Add ND/nd/ned to typos whitelist (abbreviations for Non-Dimensional in Enright-Pryce benchmarks) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes typos and a critical variable name error in benchmarks that were causing failures.
Changes
RC Circuit benchmark (fixes issue RC circuit benchmarks broken #1034)
deeref→daerefon line 88 ofRCCircuit.jmdAstroChem nelson benchmark
pallete→palettein plot parametersNonStiffODE enright_pryce
orginal→originalTypos whitelist
ND,nd, andnedto.typos.tomlTesting
Related Issues
cc @ChrisRackauckas