Skip to content

Fix gradients for parameters getting dropped #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DhairyaLGandhi wants to merge 2 commits into from
Closed

Fix gradients for parameters getting dropped #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08334d1
feat: accumulate gradients from pullback
DhairyaLGandhi Apr 3, 2025
cec46e5
chore: rm literal_getproperty dispatch
DhairyaLGandhi Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/adjoint_common.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,16 +749,16 @@ function out_and_ts(_ts, duplicate_iterator_times, sol)
return out, ts
end

if !hasmethod(Zygote.adjoint,
Tuple{Zygote.AContext, typeof(Zygote.literal_getproperty),
SciMLBase.AbstractTimeseriesSolution, Val{:u}})
Zygote.@adjoint function Zygote.literal_getproperty(sol::AbstractTimeseriesSolution,
::Val{:u})
function solu_adjoint(Δ)
zerou = zero(sol.prob.u0)
_Δ = @. ifelse(Δ === nothing, (zerou,), Δ)
(SciMLBase.build_solution(sol.prob, sol.alg, sol.t, _Δ),)
end
sol.u, solu_adjoint
end
end
# if !hasmethod(Zygote.adjoint,
# Tuple{Zygote.AContext, typeof(Zygote.literal_getproperty),
# SciMLBase.AbstractTimeseriesSolution, Val{:u}})
# Zygote.@adjoint function Zygote.literal_getproperty(sol::AbstractTimeseriesSolution,
# ::Val{:u})
# function solu_adjoint(Δ)
# zerou = zero(sol.prob.u0)
# _Δ = @. ifelse(Δ === nothing, (zerou,), Δ)
# (SciMLBase.build_solution(sol.prob, sol.alg, sol.t, _Δ),)
# end
# sol.u, solu_adjoint
# end
# end
24 changes: 11 additions & 13 deletions src/concrete_solve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,40 +415,35 @@ function DiffEqBase._concrete_solve_adjoint(
(:callback_adj, :callback))}(values(kwargs))
isq = sensealg isa QuadratureAdjoint

igs, new_u0, new_p = if _prob.f.initialization_data !== nothing
local new_u0
local new_p
igs, new_u0, new_p, inittype = if _prob.f.initialization_data !== nothing
local new_u0, new_p
iy, back = Zygote.pullback(tunables) do tunables
new_prob = remake(_prob, p = repack(tunables))
new_u0, new_p, _ = SciMLBase.get_initial_values(new_prob, new_prob, new_prob.f, SciMLBase.OverrideInit(), Val(true);
abstol = 1e-6,
reltol = 1e-6,
sensealg = SteadyStateAdjoint(autojacvec = sensealg.autojacvec))
new_tunables, _, _ = SciMLStructures.canonicalize(SciMLStructures.Tunable(), new_p)
if SciMLBase.initialization_status(_prob) == SciMLBase.OVERDETERMINED
sum(new_tunables)
else
sum(new_u0) + sum(new_tunables)
end
sum(new_u0) + sum(new_tunables)
end
igs = back(one(iy))[1] .- one(eltype(tunables))

igs, new_u0, new_p
back(one(iy))[1], new_u0, new_p, SciMLBase.NoInit()
else
nothing, u0, p
nothing, u0, p, haskey(kwargs, :initializealg) ? kwargs[:initializealg] : SciMLBase.CheckInit()
end
_prob = remake(_prob, u0 = new_u0, p = new_p)

if sensealg isa BacksolveAdjoint
sol = solve(_prob, alg, args...; initializealg = SciMLBase.NoInit(), save_noise = true,
sol = solve(_prob, alg, args...; initializealg = inittype, save_noise = true,
save_start = save_start, save_end = save_end,
saveat = saveat, kwargs_fwd...)
elseif ischeckpointing(sensealg)
sol = solve(_prob, alg, args...; initializealg = SciMLBase.NoInit(), save_noise = true,
sol = solve(_prob, alg, args...; initializealg = inittype, save_noise = true,
save_start = true, save_end = true,
saveat = saveat, kwargs_fwd...)
else
sol = solve(_prob, alg, args...; initializealg = SciMLBase.NoInit(), save_noise = true, save_start = true,
sol = solve(_prob, alg, args...; initializealg = inittype, save_noise = true, save_start = true,
save_end = true, kwargs_fwd...)
end

Expand Down Expand Up @@ -669,6 +664,7 @@ function DiffEqBase._concrete_solve_adjoint(
dp = p === nothing || p === DiffEqBase.NullParameters() ? nothing :
dp isa AbstractArray ? reshape(dp', size(tunables)) : dp

dp = Zygote.accum(dp, Δ.prob.p.tunable)
dp = Zygote.accum(dp, igs)

_, repack_adjoint = if p === nothing || p === DiffEqBase.NullParameters() ||
Expand Down Expand Up @@ -1733,6 +1729,8 @@ function DiffEqBase._concrete_solve_adjoint(
@. _out[_save_idxs] = Δ
elseif Δ isa AbstractArray{<:AbstractArray} || Δ isa AbstractVectorOfArray || Δ isa AbstractArray
@. _out[_save_idxs] = Δ[_save_idxs]
elseif isnothing(_out)
_out
else
@. _out[_save_idxs] = Δ.u[_save_idxs]
end
Expand Down
Loading