Feature/dev minor

[emrgnt-cmplxty]

🚀	This description was created by Ellipsis for commit 33ea831

feat: enhance Docker workflow and refine search logic

Summary:

Enhance Docker build workflow, adjust server command and API defaults, and refine search pipe logic.

Key points:

• Docker Workflow:
  • Add actions/checkout@v4 and echo commit hash in build-r2r-docker.yml.
  • Enable no-cache for Docker build in build-r2r-docker.yml.
• Server Command:
  • Remove unnecessary newline in server.py.
• API Defaults:
  • Change include_title_if_available default to False in retrieval_router.py.
• Search Pipe Logic:
  • Add KG_LOCAL_SEARCH_STREAM_MARKER and KG_GLOBAL_SEARCH_STREAM_MARKER in streaming_rag_pipe.py.
  • Refactor vector search results handling in streaming_rag_pipe.py.
  • Fix text assignment in vector_search_pipe.py to use result.text directly.

---

Generated with ❤️ by ellipsis.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
recommendation_platform	⬜️ Ignored (Inspect)			Sep 17, 2024 1:02am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 33ea831 in 12 seconds

More details

• Looked at 142 lines of code in 6 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. .github/workflows/build-r2r-docker.yml:100

• Draft comment:
  Using no-cache: true can significantly increase build times as it forces a fresh build every time. Consider removing it unless there's a specific need to avoid caching.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The use of no-cache: true in the Docker build step can lead to longer build times as it forces a fresh build every time. This might not be necessary unless there are specific reasons to avoid caching.

2. py/core/main/api/retrieval_router.py:130

• Draft comment:
  Changing include_title_if_available default from True to False may affect functionality if the application relies on titles being included by default. Ensure this change aligns with the intended behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The change from include_title_if_available defaulting to True to False in rag_app might affect the behavior of the application if it relies on titles being included by default. This should be verified with the intended functionality.

Workflow ID: wflow_5vdlfGbBo597Iai5

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.