Skip to content

hotfix AddDefaultInstruction #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

hotfix AddDefaultInstruction #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/Infrastructure/BotSharp.Core/Agents/Services/AgentService.GetAgents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,25 @@ public async Task<Agent> GetAgent(string id)

profile.Plugin = GetPlugin(profile.Id);

//add default instruction to ChannelInstructions
var defaultInstruction = new ChannelInstruction() { Channel = string.Empty, Instruction = profile?.Instruction };
profile.ChannelInstructions.Insert(0, defaultInstruction);
AddDefaultInstruction(profile, profile.Instruction);

return profile;
}

/// <summary>
/// Add default instruction to ChannelInstructions
/// </summary>
private void AddDefaultInstruction(Agent agent, string instruction)
{
//check if instruction is empty
if (string.IsNullOrWhiteSpace(instruction)) return;
//check if instruction is already set
if (agent.ChannelInstructions.Exists(p => p.Channel == string.Empty)) return;
//Add default instruction to ChannelInstructions
var defaultInstruction = new ChannelInstruction() { Channel = string.Empty, Instruction = instruction };
agent.ChannelInstructions.Insert(0, defaultInstruction);
}

public async Task InheritAgent(Agent agent)
{
if (string.IsNullOrWhiteSpace(agent?.InheritAgentId)) return;
Expand All @@ -98,6 +110,7 @@ public async Task InheritAgent(Agent agent)
if (string.IsNullOrWhiteSpace(agent.Instruction))
{
agent.Instruction = inheritedAgent.Instruction;
AddDefaultInstruction(agent, inheritedAgent.Instruction);
}
}
}
Loading