-
-
Notifications
You must be signed in to change notification settings - Fork 1
Fix QuizEditor selector not being used uniformly. To add date/time to versions, implement a custom dropdown selector. Fix quiz editor top layout. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EdJones
wants to merge
292
commits into
ScienceOfReading:main
Choose a base branch
from
EdJones:devel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quizset viewer layout & its integration with quizItem editor. Also add contributor badge to user widget, a new contributions modal, and a summary of contributions to the user widget.
Quizset viewer layout & its integration with quizItem editor. Also add contributor badge to user widget
… editing an item.
This reverts commit 5eea13c.
Not tested yet.
quizSets.js to order quizSets in quiztreeview.
Cursor says this should have broken the editor functions, and offered changes. But none showed up. This did fix the "Learning Science" quiz set preview.
updated the CustomDropdown component to add fork buttons for items that aren't owned by the current user. Here are the key changes: Added fork buttons to: Pending Review items Other Draft Items Permanent Quiz Items The fork button only appears if the item's userId doesn't match the current user's ID Added proper styling for the fork button: Blue background with hover effect Rounded corners Proper spacing and alignment Smooth transitions Added the handleFork function that: Prevents the dropdown from closing when clicking the fork button Calls the store's forkQuizEntry method Handles errors appropriately Improved the overall component structure: Better organization of imports Proper type definitions Improved event handling Better styling organization
Added loading state: Added isForking ref to track the forking state Added a loading spinner animation Disabled the fork button while forking Changed button text to "Forking..." during the operation Added success/error feedback: Added success message that appears after successful fork Added error message display for failed forks Both messages appear at the bottom of the dropdown Improved dropdown behavior: Reset fork states when opening the dropdown Automatically close dropdown after successful fork (with a 1.5s delay to show success message) Properly handle error states without closing the dropdown Enhanced button styling: Added disabled state styling Improved button layout with flex and gap Added loading spinner animation Maintained consistent styling across all fork buttons
Added the import for quizEntries from '../data/quiz-items' to access the static quiz entries. Modified the function to first check the static quizEntries array for the quiz with the given ID. If found in the static array, it creates a forked entry with the appropriate metadata. If not found in the static array, it then tries the Firestore collections as before. Added better error handling and logging throughout the process. The function now follows this flow: Check the static quizEntries array first If not found, check the quizEntries Firestore collection If not found, check the permanentQuizEntries Firestore collection If still not found, try searching both collections by integer ID If the entry is found in any of these locations, create a forked version with appropriate metadata If not found anywhere, throw an error
added a new section documenting the forking mechanism, which is a crucial part of the system's workflow. The new diagram shows: The decision point for forking (based on isPermanent) The fork creation process The editing workflow for forks The review and approval process The merge/rejection paths
modified the saveDraftQuizEntry function to handle both new and existing drafts. Here are the key changes: Removed the requirement for an existing document ID Added logic to handle both new and existing drafts: If there's an existing ID, it updates the document and increments the version If there's no ID, it creates a new document with version 1 Properly handles the document ID in both cases Maintains consistent state updates for both the draft and last saved entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.