Merge non-survey-related code#1247
Open
reutenauer wants to merge 4 commits into
Open
Conversation
samanrassam
approved these changes
May 25, 2026
samanrassam
left a comment
samanrassam
left a comment
There was a problem hiding this comment.
Looks clean!
Maybe I'm missing it but there's a jump from 11.5.0 to 11.5.3? Just checking in case that's not intentional.
Member
Author
|
That is intentional, versions 11.5.1 and 11.5.2 were different attempts to make the survey code work and were deployed on the order portals of the unit that wanted surveys. The code is in different branches: see 99a3 and eb3c – I just cherry-picked the relevant commits for this pull request. Since the goal is to un-messify the situation I felt that the best choice was to skip the other commits, and not to re-use version number 11.5.1, but we can of course discuss that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges all code from the past six month that is not related to surveys (only bugfixes). Cancels and replaces #1246.