SS 1516 Fix error release not in statusdata - #13
Merged
Conversation
… read timeout. Do not treat 410 Gone exceptions as consuming a retry. Better exception handling and logging.
alfredeen
marked this pull request as ready for review
September 5, 2025 13:55
churnikov
reviewed
Sep 9, 2025
…te HTTP concerns. Centralized retry, token refresh, and exception handling.
… Install jq. Kubeconfig now expected at /app/cluster.conf inside the container
… Refactor StatusQueue to take a shared session and use the new http post wrapper. Add unit tests for EventListener and StatusQueue.
churnikov
approved these changes
Sep 12, 2025
churnikov
left a comment
churnikov
left a comment
Contributor
There was a problem hiding this comment.
I think it looks good:)
I didn't read too deep into tests though, but they seem good too
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
| Timeout = Tuple[float, float] |
Contributor
There was a problem hiding this comment.
Suggested change
| Timeout = Tuple[float, float] | |
| TimeoutRange = Tuple[float, float] |
If I understand it correctly
Member
Author
There was a problem hiding this comment.
The values are not a range, but control two distinct request activities, namely connect timeout and read timeout.
Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fix to bug that occurs when the k8s event stream registers a delete event but the app (release) is not registered in the EL status queue. It also:
Note that kubeconfig is now expected at /app/cluster.conf inside the container (impacts docker compose of stackn project).