ss-1502 Serve profiling image#370
Conversation
There was a problem hiding this comment.
Is it expected that profiling will only be run using docker compose?:)
There was a problem hiding this comment.
@churnikov I think for this PR probably yes. The option to run it locally in profiling mode. But in the future we could run it in profiling on the dev instance. What do you think?
There was a problem hiding this comment.
@churnikov I probably can remove the changes I made in the CI workflow in that case.
hamzaimran08
left a comment
There was a problem hiding this comment.
It would also be good if we could switch between between profiling and normal image using e.g docker compose profiles. Even if we don't do that it would still be good to add the changes needed to docker compose file for switching between the images to the README.
@hamzaimran08 Whilst using I have instead used Env variables to give users the option of switching between the 2 modes. I'll push the code shortly. |
I agree. I think this is a good way to do it. We also have an .env.template (that gets copied to an .env file) file that can be used to set the ENV variables. I think that can be used instead of adding the variables to the command line but as long as README has instructions on how to run and switch between the profiling and normal image either way should be fine. |
Description
Jira: https://scilifelab.atlassian.net/browse/SS-1502
A wrapper image containing modules relevant to profiling and debugging Serve. The 2 modules to start with are
django-debug-toolbaranddjango-silk.Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.