Fix references to bitnami images in Dockerfile and mlflow.py#372
Merged
Conversation
Signed-off-by: Nikita Churikov <nikita@chur.ru>
Signed-off-by: Nikita Churikov <nikita@chur.ru>
kwentine
approved these changes
Aug 22, 2025
anondo1969
requested changes
Aug 22, 2025
| # https://github.com/bitnami/charts/tree/main/bitnami/postgresql#postgresql-common-parameters | ||
| "image": { | ||
| "repository": "bitnamilegacy/postgresql", | ||
| "tag": "postgresql:17.5.0-debian-12-r12", |
Member
There was a problem hiding this comment.
I think 'postgresql:' should be removed from the 'tag' here. It will create a duplicate of it otherwise. I also tried it locally and got the following 'InvalidImageName' status with this in pod description. Removing it fixes the problem and it works fine.
Failed to apply default image tag "docker.io/bitnamilegacy/postgresql:postgresql:17.5.0-debian-12-r12": couldn't parse image name "docker.io/bitnamilegacy/postgresql:postgresql:17.5.0-debian-12-r12": invalid reference format
Signed-off-by: Nikita Churikov <nikita@chur.ru>
Signed-off-by: Nikita Churikov <nikita@chur.ru> # Conflicts: # Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change satisfies updates from bitnami/containers#83267
Types of changes
To indicate the type of change (such as bugfix or new feature), use a github pull request label.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!