Skip to content

Fix references to bitnami images in Dockerfile and mlflow.py#372

Merged
churnikov merged 4 commits into
developfrom
SS-1503-bitnami-to-bitnamilegacy-migration
Aug 25, 2025
Merged

Fix references to bitnami images in Dockerfile and mlflow.py#372
churnikov merged 4 commits into
developfrom
SS-1503-bitnami-to-bitnamilegacy-migration

Conversation

@churnikov

Copy link
Copy Markdown
Contributor

Description

This change satisfies updates from bitnami/containers#83267

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

Signed-off-by: Nikita Churikov <nikita@chur.ru>
@churnikov churnikov self-assigned this Aug 15, 2025
@churnikov churnikov marked this pull request as ready for review August 19, 2025 08:53
@churnikov churnikov requested a review from a team as a code owner August 19, 2025 08:53

@anondo1969 anondo1969 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@churnikov churnikov requested a review from a team August 21, 2025 10:07
Signed-off-by: Nikita Churikov <nikita@chur.ru>
@anondo1969 anondo1969 self-requested a review August 22, 2025 13:04
Comment thread apps/models/app_types/mlflow.py Outdated
# https://github.com/bitnami/charts/tree/main/bitnami/postgresql#postgresql-common-parameters
"image": {
"repository": "bitnamilegacy/postgresql",
"tag": "postgresql:17.5.0-debian-12-r12",

@anondo1969 anondo1969 Aug 22, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'postgresql:' should be removed from the 'tag' here. It will create a duplicate of it otherwise. I also tried it locally and got the following 'InvalidImageName' status with this in pod description. Removing it fixes the problem and it works fine.

Failed to apply default image tag "docker.io/bitnamilegacy/postgresql:postgresql:17.5.0-debian-12-r12": couldn't parse image name "docker.io/bitnamilegacy/postgresql:postgresql:17.5.0-debian-12-r12": invalid reference format

Signed-off-by: Nikita Churikov <nikita@chur.ru>

@anondo1969 anondo1969 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Nikita Churikov <nikita@chur.ru>

# Conflicts:
#	Dockerfile
@churnikov churnikov merged commit a2005a9 into develop Aug 25, 2025
2 checks passed
@churnikov churnikov deleted the SS-1503-bitnami-to-bitnamilegacy-migration branch August 25, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants