SS-1953 New field for keywords from controlled vocabularies

[akochari]

Description

This addresses SS-1953. In this PR, I am adding a new JSON field to store info about keywords. User selects keywords from controlled vocabularies, we save the subject, vocabulary name (scheme), and keyword id (classification code). This is the field that also underlies the keywords displayed in the interface, used for filtering, sent to invenio.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

• This pull request is against develop branch (not applicable for hotfixes)
• I have included a link to the issue on GitHub or JIRA (if any)
• I have included migration files (if there are changes to the model classes)
• I have added or updated unit and end2end tests or a manual test case to complement my changes
• I have ran unit and end2end tests
• I have updated the related documentation (if necessary)
• I have added a reviewer for this pull request
• I have added myself as an author for this pull request
• In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts
• In case your changes are large enough, did you deploy your changes to develop instance?

[hamzaimran08]

Looks great in general, just a couple of suggestions/questions

In templates/common/app_metadata.html should we change this

<dt class="col-sm-4">Tags</dt>
<dd class="col-sm-8">
    {% for tag in app.tags.all %}
  <a class="tag me-1 mb-1" onclick="searchByTag('{{ tag | title }}','card-keyword',this)">
    <span class="badge text-bg-primary badge-grape badge-ico" style="margin-right: -0.2rem;">
      <div class="fas fa-tag fa-sm me-1"></div>
      <span class="tag-name">{{ tag |title }}</span>
    </span>
  </a>
  {% endfor %}
</dd>

to

<dt class="col-sm-4">Subjects & keywords</dt>
<dd class="col-sm-8">
    {% for keyword in app.subjects_keywords %}
  <a class="tag me-1 mb-1" onclick="searchByTag('{{ keyword.subject | title }}','card-keyword',this)">
    <span class="badge text-bg-primary badge-grape badge-ico" style="margin-right: -0.2rem;">
      <div class="fas fa-tag fa-sm me-1"></div>
      <span class="tag-name">{{ keyword.subject |title }}</span>
    </span>
  </a>
  {% endfor %}
</dd>

Also, in app/helpers.py should we also change:

Line 392 to subjects_keywords instead of tags

Line 685-686 to

subjects_keywords_data = form.cleaned_data.get("subjects_keywords") if hasattr(form, "cleaned_data") else None
logger.debug(f"Background task: subjects_keywords data from form: {subjects_keywords_data}")

And Line 693 to "subjects_keywords": form.cleaned_data.get("subjects_keywords")

[akochari]

Thanks, Hamza. I now made all the changes.
The app_metadata.html is the old template which is not going to be used anymore but I made the change there too just in case we delay the rollout.

[hamzaimran08]

LGTM